Skip to content

Conversation

jgoday
Copy link
Contributor

@jgoday jgoday commented Aug 15, 2025

Correct the InMemory file name downloaded when using a dependency with URL + query parameters.
Simple test added in 'modules/build/src/test/scala/scala/build/tests/SourcesTests.scala'.

fixes #3720.

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, sorry for the late review!
Commented on a small nitpick, otherwise looks good

Copy link
Contributor

@Gedochao Gedochao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!
The failures on the CI are caused by #3841
Will need to rebase on top of main once #3842 gets merged.

@Gedochao
Copy link
Contributor

(rebased the branch)

@Gedochao Gedochao merged commit da99e0e into VirtusLab:main Aug 29, 2025
104 of 110 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"using file" with URL+query parameters is broken
2 participants